fix(MediaFiles): return missing 'lastModified' and 'end' attributes #195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
www
Motivation and Context
Returned MediaFiles objects for captured media are missing
lastModified
(null) andend
(0).Description
The helpers.wrapMediaFiles method is using the MediaFile empty constructor, and attributes are set afterward.
But given MediaFile constructor is simply calling its parent cordova-plugin-file.File constructor, we can understand that some File attributes will never be redefined properly.
Directly calling the constructor with all the params values resolves this problem in a clean manner.
Testing
Returned MediaFiles objects now have correct
lastModified
===lastModifiedDate
, andend
===size
.Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)